Fix MTS Resource Loading & Null Safety for Continuity(Compatibility with the mod immersive vehicles)#709
Closed
hongkevin233 wants to merge 8 commits intoPepperCode1:1.20.1/devfrom
Closed
Conversation
fixed the bug that cant accept “null” from resource manerger, and this bug used to cause crash
fixed the bug that load resource from null ( optimized the logic for detecting whether a resource pack is an MTS resource pack, reducing false positives.)
Added MTS resource pack validation through pack.mcmeta parsing 2. Implemented checks for null input streams to prevent NPE crashes 3. Added namespace filtering to reduce unnecessary resource loading 4. Enhanced error logging with specific pack and path information 5. Added validation for dependent textures in CTM configurations
Owner
|
Compatibility was fixed on Immersive Vehicle's side about 2 weeks ago in DonBruce64/MinecraftTransportSimulator@1ffdd58, but a release was not made with that fix yet. These changes are not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves two critical issues in Continuity: unintended MTS pack resource loading and NPE crashes from invalid input streams—with targeted changes across 3 core classes (backward-compatible for non-MTS packs).
Key Changes
ResourceRedirectHandler.java
CtmPropertiesLoader.java
AtlasLoaderMixin.java
MTS Pack Requirement
Add
mtsfield topack.mcmeta(example) for validation:{
"mts": {
"validResources": ["mts:textures/block/stone.png"],
"validCtmPaths": ["optifine/ctm/mts_stone.ctm.properties"]
}
}
Fixed Issues